Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-464 Revert #29

Merged
merged 10 commits into from
Feb 5, 2021
Merged

FISH-464 Revert #29

merged 10 commits into from
Feb 5, 2021

Conversation

Pandrex247
Copy link
Member

We believe this PR is causing the JAXR TCK to fail.
#26

@Pandrex247
Copy link
Member Author

Note that since this reverts David's fix for an HTTP2 test, the build tests fail again now.

@Pandrex247
Grizzly 2.4.4.payara-p6
277c777 
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247
Next dev iteration
65004e2 
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247
Copy link
Member Author

Also includes version incremenets.
Tag here: https://github.com/payara/patched-src-grizzly/tree/2.4.4.payara-p6

This was referenced Feb 5, 2021
Merged
Merged
@MattGill98 MattGill98 merged commit 185eaf3 into payara:2.4.4.payara-maintenance Feb 5, 2021
@dmatej
Copy link

dmatej commented Feb 5, 2021

Note that since this reverts David's fix for an HTTP2 test, the build tests fail again now.

The same changes in Eclipse's version 3.0.0 passed all TCK tests in GlassFish (except jakarta package names), so how it could cause issues in Payara?

@dmatej
Copy link

dmatej commented Feb 5, 2021

Sad you didn't tell me, I could try to reproduce it.

@dmatej
Copy link

dmatej commented Feb 6, 2021 •
edited
Loading

JAXR TCK nightly result of 5.2021.1-RC1 on my machine, so I believe the cause is something else (JDK version? Another race condition? (unusual in TCK as these tests are mostly single threaded)):
image
I will start it once more with different CPU settings. But if you can send me a link to logs on jenkins, it would simplify diagnostic of the real cause.

@Pandrex247 Pandrex247 deleted the FISH-464-Revert branch February 8, 2021 15:28
@Pandrex247 Pandrex247 mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGill98 MattGill98 MattGill98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandrex247 @dmatej @MattGill98