Replace is_some_and with map_or for MSRV #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_some_and is stable only in Rust 1.70.0 and greater.
map_or(false, |s| s.eq_ignore_ascii_case(SCHEME)):
- This method is used to handle the Option returned by get().
- If get() returns None (i.e., the string is too short), map_or()
returns false.
- If get() returns Some(s), it applies the closure
|s| s.eq_ignore_ascii_case(SCHEME).
- This closure checks if the substring s is equal to SCHEME,
ignoring ASCII case differences.
- If they are equal, it returns true; otherwise, it returns
false.
DanGould
force-pushed
the
fix-scheme-fix
branch
from
dbedeb3 to
59f464c
Compare
|
Confirmed passes in CI by #1's 1.63.0 run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_some_and is stable only in Rust 1.70.0 and greater.