Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always paying full RequiredReserve instead of topping it up #76

Closed
DanGould opened this issue Nov 19, 2022 · 0 comments · Fixed by #78
Closed

Always paying full RequiredReserve instead of topping it up #76

DanGould opened this issue Nov 19, 2022 · 0 comments · Fixed by #78
Labels
bug Something isn't working

Comments

@DanGould
Copy link
Contributor

RequiredReserve rpc "returns the minimum amount of satoshis that should be kept in the wallet in order to fee bump anchor channels if necessary"

Right now we're always adding that amount to the bip21 amount, when in reality we should only be adding the difference between our current on-chain reserve and the rquired reserve if the amount in the wallet is < the reserve

@DanGould DanGould changed the title RequiredReserve asked for rather than kept Always paying full RequiredReserve instead of topping it up Nov 19, 2022
@DanGould DanGould added the bug Something isn't working label Nov 19, 2022
DanGould added a commit to DanGould/nolooking that referenced this issue Nov 20, 2022
Fix payjoin#76. Lnd's RequiredReserve returns the amount the wallet needs
to have when it opens a channel. Only add reserve amount if it is
missing from the wallet's total balance
DanGould added a commit to DanGould/nolooking that referenced this issue Nov 20, 2022
Fix payjoin#76. Lnd's RequiredReserve returns the amount the wallet needs
to have when it opens a channel. Only add reserve amount if it is
missing from the wallet's total balance
DanGould added a commit that referenced this issue Nov 20, 2022
Fix #76. Lnd's RequiredReserve returns the amount the wallet needs
to have when it opens a channel. Only add reserve amount if it is
missing from the wallet's total balance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant