Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on payjoin crate #1

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Aug 7, 2022

This works on a custom branch of the payjoin crate. That's because we need rust-bitcoin v28+ which is not merged and probably will not be until rust-bitcoin v29 is released

@DanGould DanGould marked this pull request as ready for review August 10, 2022 10:53
@DanGould
Copy link
Contributor Author

This functions. I think it's sufficient to create an integration test with

Co-authored-by: evanlinjin <hello@evanlinjin.me>
Copy link
Collaborator

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's check everything still works locally before we merge. We will work on testing later.

@DanGould DanGould merged commit 07e301d into payjoin:master Aug 14, 2022
@DanGould DanGould deleted the rust-payjoin branch August 14, 2022 06:13
@DanGould
Copy link
Contributor Author

tested with payjoin-client & polar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants