Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split lightning client logic from main #11

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Split lightning client logic from main #11

merged 3 commits into from
Oct 4, 2022

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Aug 15, 2022 •
edited
Loading

Piecemeal additions of the new LndClient abstraction from #10. Ready for review

@DanGould DanGould marked this pull request as ready for review August 16, 2022 05:58
@DanGould DanGould changed the title Split main Split lightning client logic from main Aug 16, 2022
@DanGould
Copy link
Contributor Author

DanGould commented Oct 4, 2022

Tested

@DanGould DanGould merged commit 0b7d005 into payjoin:master Oct 4, 2022
@DanGould DanGould deleted the split-main branch October 4, 2022 13:19
@DanGould DanGould mentioned this pull request Oct 4, 2022
Open
10 tasks
@DanGould
Copy link
Contributor Author

DanGould commented Oct 4, 2022

This is missing verify_funding from #10 which is feature-equivalent to these lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanGould