Test test ❌ #39
Test test ❌ #39
Conversation
|
Aha, the test passes despite a panicked thread. Two things need to be done:
|
|
oh.. I accidentally killed the nginx I missed it because the test was passing regardless of a channel open |
DanGould
force-pushed
the
test-test
branch
3 times, most recently
from
4a888d3 to
f5083d1
Compare
| @@ -0,0 +1 @@ | |||
| # this file keeps the directory around for tests | |||
There was a problem hiding this comment.
Can this be an empty .gitignore?
There was a problem hiding this comment.
I force-pushed a .gitignore. The rest is the same
|
yeah you knew it, damn docker L179 integration.rs needs 172.17.0.1. Also maybe cherry-pick /pull this commit onto your test-test branch, makes tests fail depending on test success. |
|
@nickfarrow Huzzah!!! you fixed it! This one was a headache to find. Binding to 172.17.0.2 doesn't run on my mac however, so we need a dynamic var to bind to. |
Without binding to the bridge the gateway fails on GitHub actions.
By adding a `test_succeeded` bool to the test `Fixture` we can update it to `true` once the test case has been completed. After `drop(self)` runs the docker cleanup, if `test_succeeded` is false then we force a panic to reflect the failed test.
|
Nice! LGTM. Let me run locally |
#13 passed CI when it should not have, because the loin server failed to connect. However, it passes with a successful payjoin on my machine. I'm pushing this to run CI and see if I can replicate the problem.
https://github.com/chaincase-app/nolooking/actions/runs/3325555814
/jobs/5498363364