Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format repository and add test to workflow #45

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

nickfarrow
Copy link
Collaborator

fixes #42

This should be merged only after all substantial code change PRs have been merged so we can avoid rebases.

(I'm also testing the github CI using this PR)

@nickfarrow nickfarrow force-pushed the format branch 3 times, most recently from 4ba62eb to 7fc7a70 Compare November 3, 2022 06:11
@DanGould
Copy link
Contributor

DanGould commented Nov 5, 2022

ready for review after rebase?

@nickfarrow nickfarrow marked this pull request as ready for review November 6, 2022 10:48
@DanGould
Copy link
Contributor

DanGould commented Nov 6, 2022

cargo +nightly fmt
git diff nickfarrow/format

looks clean to me ACK 6ea4bb4

Doesn't this checkout an extra time? What's stopping you from running the following at the end of the build job as just a step?

- uses: https://github.com/actions-rs/toolchain/tree/v1v1
        with:
          profile: minimal
          toolchain: nightly
          override: true
          components: rustfmt
      - uses: https://github.com/actions-rs/cargo/tree/v1v1
        with:
          command: fmt
          args: --all -- --check

@DanGould DanGould merged commit ad32cb4 into payjoin:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rustfmt to CI
2 participants