Fix channel queue #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfarrow
force-pushed
the
fix-channel-queue
branch
2 times, most recently
from
4a65248 to
78fb3a8
Compare
0xBEEFCAF3
approved these changes
Nov 17, 2022
|
Are you leaving fixup commits to be squashed? I'm confused why they're not |
|
This structure makes so much more sense |
nickfarrow
force-pushed
the
fix-channel-queue
branch
from
088fee0 to
c1735f2
Compare
|
I find it easier to track changes than comparing forcepushes (maintains linear and modular history), Squash and Merge should get rid of them |
Move labels outside channels grid. Get length of children, not NaN. Count nodes using labels correctly dividing by 2.
DanGould
force-pushed
the
fix-channel-queue
branch
from
c1735f2 to
7aab14e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We somehow missed these in a8ca6eb
Move labels outside channels grid.
Get length of children, not NaN.
Count nodes using labels correctly dividing by 2.