chore: upgrade to TypeScript 5.7, ensure tsconfig targed and lib prop…

…erties match the APIs we support (#9473) TS 5.7 added support for ES2024. By keeping target: “esnext”, we would have accidentally set our minimum supported ES version to ES2024. This sets it to ES2022, which is the version supported by Node 18
payloadcms · Nov 23, 2024 · 13fc94d · 13fc94d
1 parent 23d54a7
commit 13fc94d
Show file tree

Hide file tree

Showing 47 changed files with 357 additions and 322 deletions.
diff --git a/.github/actions/release-commenter/tsconfig.json b/.github/actions/release-commenter/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": ["es2020.string"],
     "noEmit": true,
     "strict": true,

diff --git a/.github/actions/triage/tsconfig.json b/.github/actions/triage/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": ["es2020.string"],
     "noEmit": true,
     "strict": true,

diff --git a/examples/auth/next-app/tsconfig.json b/examples/auth/next-app/tsconfig.json
@@ -1,7 +1,11 @@
 {
   "compilerOptions": {
-    "target": "es5",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "target": "ES2022",
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "allowJs": true,
     "skipLibCheck": true,
     "strict": true,

diff --git a/examples/auth/next-pages/tsconfig.json b/examples/auth/next-pages/tsconfig.json
@@ -1,10 +1,10 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,

diff --git a/examples/auth/payload/tsconfig.json b/examples/auth/payload/tsconfig.json
@@ -1,7 +1,11 @@
 {
   "compilerOptions": {
     "baseUrl": ".",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "allowJs": true,
     "skipLibCheck": true,
     "strict": true,

diff --git a/examples/custom-components/tsconfig.json b/examples/custom-components/tsconfig.json
@@ -2,9 +2,9 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,
@@ -33,7 +33,7 @@
         "src/payload-types.ts"
       ]
     },
-    "target": "ES2017"
+    "target": "ES2022",
   },
   "include": [
     "next-env.d.ts",

diff --git a/examples/draft-preview/next-app/tsconfig.json b/examples/draft-preview/next-app/tsconfig.json
@@ -1,7 +1,11 @@
 {
   "compilerOptions": {
-    "target": "es5",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "target": "ES2022",
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "allowJs": true,
     "skipLibCheck": true,
     "strict": true,

diff --git a/examples/draft-preview/next-pages/tsconfig.json b/examples/draft-preview/next-pages/tsconfig.json
@@ -1,10 +1,10 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,

diff --git a/examples/draft-preview/payload/tsconfig.json b/examples/draft-preview/payload/tsconfig.json
@@ -1,10 +1,10 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "strict": false,

diff --git a/examples/email/tsconfig.json b/examples/email/tsconfig.json
@@ -2,9 +2,9 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,
@@ -33,7 +33,7 @@
         "src/payload-types.ts"
       ]
     },
-    "target": "ES2017"
+    "target": "ES2022",
   },
   "include": [
     "next-env.d.ts",

diff --git a/examples/form-builder/next-app/tsconfig.json b/examples/form-builder/next-app/tsconfig.json
@@ -1,10 +1,10 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,

diff --git a/examples/form-builder/next-pages/tsconfig.json b/examples/form-builder/next-pages/tsconfig.json
@@ -1,10 +1,10 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,

diff --git a/examples/form-builder/payload/tsconfig.json b/examples/form-builder/payload/tsconfig.json
@@ -2,9 +2,9 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,
@@ -30,7 +30,7 @@
         "./src/payload.config.ts"
       ]
     },
-    "target": "ES2017"
+    "target": "ES2022",
   },
   "include": [
     "next-env.d.ts",

diff --git a/examples/live-preview/next-app/tsconfig.json b/examples/live-preview/next-app/tsconfig.json
@@ -1,7 +1,11 @@
 {
   "compilerOptions": {
-    "target": "es5",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "target": "ES2022",
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "allowJs": true,
     "skipLibCheck": true,
     "strict": true,

diff --git a/examples/live-preview/next-pages/tsconfig.json b/examples/live-preview/next-pages/tsconfig.json
@@ -1,10 +1,10 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2022",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,

diff --git a/examples/live-preview/payload/tsconfig.json b/examples/live-preview/payload/tsconfig.json
@@ -1,7 +1,11 @@
 {
   "compilerOptions": {
     "baseUrl": ".",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "allowJs": true,
     "skipLibCheck": true,
     "strict": true,

diff --git a/examples/multi-tenant/tsconfig.json b/examples/multi-tenant/tsconfig.json
@@ -2,9 +2,9 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,
@@ -33,7 +33,7 @@
         "src/payload-types.ts"
       ]
     },
-    "target": "ES2017"
+    "target": "ES2022",
   },
   "include": [
     "next-env.d.ts",

diff --git a/examples/tailwind-shadcn-ui/tsconfig.json b/examples/tailwind-shadcn-ui/tsconfig.json
@@ -2,9 +2,9 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,
@@ -30,7 +30,7 @@
         "./src/payload.config.ts"
       ]
     },
-    "target": "ES2017"
+    "target": "ES2022",
   },
   "include": [
     "next-env.d.ts",

diff --git a/examples/testing/tsconfig.json b/examples/testing/tsconfig.json
@@ -1,7 +1,11 @@
 {
   "compilerOptions": {
-    "target": "es5",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "target": "ES2022",
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "outDir": "./dist",
     "skipLibCheck": true,
     "strict": false,

diff --git a/examples/whitelabel/tsconfig.json b/examples/whitelabel/tsconfig.json
@@ -2,9 +2,9 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
     ],
     "allowJs": true,
     "skipLibCheck": true,
@@ -33,7 +33,7 @@
         "src/payload-types.ts"
       ]
     },
-    "target": "ES2017"
+    "target": "ES2022",
   },
   "include": [
     "next-env.d.ts",

diff --git a/package.json b/package.json
@@ -166,7 +166,7 @@
     "tempy": "1.0.1",
     "tsx": "4.19.2",
     "turbo": "^2.1.3",
-    "typescript": "5.6.3"
+    "typescript": "5.7.2"
   },
   "peerDependencies": {
     "react": "^19.0.0 || ^19.0.0-rc-65a56d0e-20241020",

diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -40,7 +40,7 @@
     "eslint-plugin-react-hooks": "5.0.0",
     "eslint-plugin-regexp": "2.6.0",
     "globals": "15.12.0",
-    "typescript": "5.6.3",
+    "typescript": "5.7.2",
     "typescript-eslint": "8.14.0"
   }
 }
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -39,7 +39,7 @@
     "eslint-plugin-react-hooks": "5.0.0",
     "eslint-plugin-regexp": "2.6.0",
     "globals": "15.12.0",
-    "typescript": "5.6.3",
+    "typescript": "5.7.2",
     "typescript-eslint": "8.14.0"
   }
 }
diff --git a/packages/payload/tsconfig.json b/packages/payload/tsconfig.json
@@ -13,7 +13,11 @@
       "payload/types": ["./src/types/index.ts"]
     },
     "types": ["jest", "node", "@types/jest"],
-    "lib": ["dom", "dom.iterable", "esnext"]
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
   },
   "exclude": [
     "dist",

diff --git a/packages/translations/package.json b/packages/translations/package.json
@@ -63,7 +63,7 @@
     "@types/react-dom": "npm:types-react-dom@19.0.0-rc.1",
     "dotenv": "16.4.5",
     "prettier": "3.3.3",
-    "typescript": "5.6.3"
+    "typescript": "5.7.2"
   },
   "publishConfig": {
     "exports": {

diff --git a/packages/translations/tsconfig.json b/packages/translations/tsconfig.json
@@ -7,7 +7,11 @@
     "allowJs": true,
     "outDir": "./dist" /* Specify an output folder for all emitted files. */,
     "rootDir": "./src",
-    "lib": ["dom", "dom.iterable", "esnext"],
+    "lib": [
+      "DOM",
+      "DOM.Iterable",
+      "ES2022"
+    ],
     "noEmit": false /* Do not emit outputs. */,
     "emitDeclarationOnly": false
   },

diff --git a/packages/ui/src/elements/TableColumns/index.tsx b/packages/ui/src/elements/TableColumns/index.tsx
@@ -194,7 +194,7 @@ export const TableColumnsProvider: React.FC<Props> = ({
             active: activeColumnAccessors.includes(col.accessor),
           }
         })
-        .toSorted((first, second) => {
+        .sort((first, second) => {
           const indexOfFirst = activeColumnAccessors.indexOf(first.accessor)
           const indexOfSecond = activeColumnAccessors.indexOf(second.accessor)
 
@@ -204,7 +204,6 @@ export const TableColumnsProvider: React.FC<Props> = ({
 
           return indexOfFirst > indexOfSecond ? 1 : -1
         })
-
       const { state: columnState, Table } = await getTableState({
         collectionSlug,
         columns: activeColumns,