Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bold/italic shortcuts still work even if their features are not included #8811

Closed
GermanJablo opened this issue Oct 21, 2024 · 2 comments · Fixed by #9507
Closed

bold/italic shortcuts still work even if their features are not included #8811

GermanJablo opened this issue Oct 21, 2024 · 2 comments · Fixed by #9507
Assignees
@GermanJablo

Comments

@GermanJablo
Copy link
Contributor

Describe the Bug

One user reported: "We have noticed that the bold/italic shortcuts still work in the Lexical editor even if the BoldFeature/ItalicFeature are not included."

Until we fix this, you can temporarily use this workaround in your code.

Link to the code that reproduces this issue

https://github.com/payloadcms/payload

Reproduction Steps

  1. disable Bold Feature/Italic Feature in any test suite inside folder folder.
  2. run it and test it with pnpm dev [folder]

Which area(s) are affected? (Select all that apply)

plugin: richtext-lexical

Environment Info

Payload: beta.112
@GermanJablo GermanJablo added status: needs-triage Possible bug which hasn't been reproduced yet v3 labels Oct 21, 2024
@GermanJablo GermanJablo self-assigned this Oct 21, 2024
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Oct 21, 2024
@denolfe denolfe removed the v3 label Nov 19, 2024
@GermanJablo GermanJablo mentioned this issue Nov 25, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🚀 This is included in version v3.2.0

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
kendelljoseph pushed a commit that referenced this issue Feb 21, 2025
@GermanJablo @kendelljoseph
fix(richtext-lexical): prevent use of text formats whose features wer…
4493c5e 
…e not enabled (#9507)

Fixes #8811

Before this PR, even if you did not include text formatting features
(such as BoldFeature, ItalicFeature, etc), it was possible to apply that
formatting by (a) pasting content from the clipboard and (b) using
keyboard shortcuts.

This PR fixes that by requiring the formatting features to be registered
so that they can be inserted in the editor.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GermanJablo GermanJablo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@denolfe @GermanJablo