Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableListColumn and disableListFilter are ignored if user has column / filter applied before the disable is enabled #9774

Closed
tyteen4a03 opened this issue Dec 5, 2024 · 2 comments · Fixed by #9874
Closed

disableListColumn and disableListFilter are ignored if user has column / filter applied before the disable is enabled #9774

tyteen4a03 opened this issue Dec 5, 2024 · 2 comments · Fixed by #9874
Assignees
@jacobsfletch
Labels
created-by: Contributor validate-reproduction

Comments

@tyteen4a03
Copy link
Contributor

Describe the Bug

The disableListColumn and disableListFilter are ignored if user has column / filter applied before the disable is enabled.

Link to the code that reproduces this issue

https://github.com/tyteen4a03/payload-list-bug

Reproduction Steps

  1. Create two entries in the Media collection (mine has upload disabled), with the alt text a and b respectively.
  2. Go to the list UI, and apply a filter for alt text to equal a.
  3. Enable disableListColumn and disableListFilter in the collection definition.
  4. Refresh the UI. The list column and filters are still applied.

Which area(s) are affected? (Select all that apply)

area: ui

Environment Info

Node.js v22.11.0

Binaries:
  Node: 22.11.0
  npm: 10.9.0
  Yarn: N/A
  pnpm: 9.13.0
Relevant Packages:
  payload: 3.4.0
  next: 15.0.3
  @payloadcms/db-mongodb: 3.4.0
  @payloadcms/email-nodemailer: 3.4.0
  @payloadcms/graphql: 3.4.0
  @payloadcms/next/utilities: 3.4.0
  @payloadcms/payload-cloud: 3.4.0
  @payloadcms/richtext-lexical: 3.4.0
  @payloadcms/translations: 3.4.0
  @payloadcms/ui/shared: 3.4.0
  react: 19.0.0-rc-66855b96-20241106
  react-dom: 19.0.0-rc-66855b96-20241106
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000
  Available memory (MB): 32768
  Available CPU cores: 10
@tyteen4a03 tyteen4a03 added status: needs-triage Possible bug which hasn't been reproduced yet validate-reproduction labels Dec 5, 2024
@jacobsfletch jacobsfletch added validate-reproduction and removed status: needs-triage Possible bug which hasn't been reproduced yet labels Dec 5, 2024
@jacobsfletch jacobsfletch self-assigned this Dec 9, 2024
@jacobsfletch jacobsfletch mentioned this issue Dec 10, 2024
Merged
jacobsfletch added a commit that referenced this issue Dec 10, 2024
@jacobsfletch
fix(ui): refreshes column state during hmr and respects admin.disable…
f7172b5 
…ListColumn despite preferences (#9846)

Partial fix for #9774. When `admin.disableListColumn` is set
retroactively, it continues to appear in column state, but shouldn't.
This was because the table column context was not refreshing after HMR
runs, and would instead hold onto these stale columns until the page
itself refreshes. Similarly, this was also a problem when the user had
saved any of these columns to their list preferences, where those prefs
would take precedence despite these properties being set on the
underlying fields. The fix is to filter these columns from all requests
that send them, and ensure local component state properly refreshes
itself.
@jacobsfletch jacobsfletch mentioned this issue Dec 10, 2024
Merged
@jacobsfletch jacobsfletch linked a pull request Dec 10, 2024 that will close this issue
fix(ui): ensures admin.disableListFilter is disabled despite url search params #9874
Merged
jacobsfletch added a commit that referenced this issue Dec 10, 2024
@jacobsfletch
fix(ui): ensures admin.disableListFilter is disabled despite url sear…
da6bc55 
…ch params (#9874)

Continuation of #9846 and partial fix for #9774. When setting
`admin.disableListFilter` retroactively, it remains active within the
list filter controls. Same for when the URL search query contains one of
these fields, except this will actually display the _wrong_ field,
falling back to the _first_ field from the config. The fix is to
properly disable the condition for this field if it's an active filter,
while still preventing it from ever rendering as an option within the
field selector itself.
@github-actions GitHub Actions
Copy link
Contributor

🚀 This is included in version v3.6.0

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jacobsfletch jacobsfletch

Labels
created-by: Contributor validate-reproduction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): ensures admin.disableListFilter is disabled despite url search params payloadcms/payload
2 participants
@tyteen4a03 @jacobsfletch