Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): properly allows configuring rows for the textarea field #10031

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

PatrikKozak
Copy link
Contributor

What?

Previously, setting the admin.rows property did not change the height of the textarea field input.

Why?

Although rows was being properly set on the textarea element - it's absolute positioning prevented the height from actually changing.

How?

Updates the styles of the textarea field component to properly allow the rows prop to change the height of the field.

Example w/:

{
  name: 'someTextArea',
  type: 'textarea',
  admin: {
    rows: 5,
  }
}

Before:
Screenshot 2024-12-17 at 2 50 19 PM

After:
Screenshot 2024-12-17 at 2 50 00 PM

Fixes #10017

@PatrikKozak PatrikKozak changed the title fix(ui): properly allows configuring rows for the textarea field fix(ui): properly allows configuring rows for the textarea field Dec 17, 2024
@PatrikKozak PatrikKozak merged commit 61c5e0d into main Dec 17, 2024
72 checks passed
@PatrikKozak PatrikKozak deleted the fix/textarea-rows branch December 17, 2024 20:46
Copy link
Contributor

🚀 This is included in version v3.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row in textarea not responding
1 participant