Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint wasn't running in test dir #11036

Merged
merged 2 commits into from
Feb 7, 2025
Merged

chore: fix eslint wasn't running in test dir #11036

merged 2 commits into from
Feb 7, 2025
+1 −4

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Feb 7, 2025 •
edited
Loading

This PR fixes 2 eslint config issues that prevented it from running in our test dir

  • spec files were ignored by the root eslint config. This should have only ignored spec files within our packages, as they are ignored by the respective package tsconfigs
  • defining the payload plugin crashed eslint in our test dir, as it was already defined in the root eslint config it was inheriting

@AlessioGr AlessioGr enabled auto-merge (squash) February 7, 2025 03:23
@AlessioGr AlessioGr disabled auto-merge February 7, 2025 03:23
@AlessioGr AlessioGr enabled auto-merge (squash) February 7, 2025 03:24
@AlessioGr AlessioGr merged commit 257cad7 into main Feb 7, 2025
67 checks passed
@AlessioGr AlessioGr deleted the chore/fix-eslint-in-tests-dir branch February 7, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
created-by: Payload team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlessioGr