chore(next): handles preferences routes #5041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
requested review from
denolfe,
jmikrut and
DanRibbens
as code owners
|
Hmm after further review I think this PR is probably unneeded. These routes are supposed to be attached as custom endpoints onto the preferences collection itself. Will close or change as needed. |
1 task
|
Succeeded by #5042. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properly handles the
/payload-preferencesand/payload-preferences/:idroutes by piping them through to their respective operations. These routes were only being caught before because of the base collection route handlers. But the problem with that is that preferences need to find their document by key and not document ID, i.e./payload-preferences/:key. These operations also properly handle the user, etc.