Skip to content

Conversation

@r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Sep 27, 2024

Adds a note about admin.condition when using custom field component.

@r1tsuu r1tsuu changed the title chore(docs): add note about condition with custom field component docs: add note about condition with custom field component Sep 27, 2024
@r1tsuu r1tsuu force-pushed the docs/improve-documentation-for-condition-when-using-custom-field-component branch from 45ea885 to 2b309f3 Compare September 27, 2024 00:29
@r1tsuu r1tsuu force-pushed the docs/improve-documentation-for-condition-when-using-custom-field-component branch from 2b309f3 to 4233df8 Compare September 27, 2024 00:31
@jacobsfletch
Copy link
Member

This could likely be wired up so that the custom wrapper is unnecessary. Especially with #8364. We should explore this further.

@DanRibbens DanRibbens self-requested a review October 24, 2024 19:20
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! I approved before I saw this comment #8440 (comment).
That would be nice.

Should we close this PR?

@r1tsuu
Copy link
Member Author

r1tsuu commented Oct 24, 2024

Likely

@r1tsuu r1tsuu closed this Oct 24, 2024
@r1tsuu r1tsuu deleted the docs/improve-documentation-for-condition-when-using-custom-field-component branch October 24, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants