fix(ui): safely accesses field in default filter component #9276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
approved these changes
Nov 18, 2024
jacobsfletch
changed the title
|
🚀 This is included in version v3.0.0-beta.135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the WhereBuilder Condition DefaultFilter component, there is a switch statement that contains components to return based on the built filter in the admin ui. Having a filter built out then navigating to another collection list view causes an error to occur due to InternalField being undefined but the DefaultFilter tries to access the field on it.
Why?
To fix unexpected
cannot access property field of undefinederrors.How?
Adding a conditional chaining operator.
Odd thing here is that the
Textcomponent where this error originates from doesn't actually make use of the passedInternalField. Might be worth it to take a closer look at it.Fixes #9179