Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): passes doc through edit view handler #9302

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Nov 18, 2024

The Edit and Live Preview views were duplicately making the same Local API requests for document data. This is because while the top-level document view handler makes these requests before rendering the Live Preview view, it wasn't passing it's data through as props. This has also led to inconsistencies in the options being passed through the requests themselves, such as locale, user, and overrideAccess: false. Everything is now standardized as expected through the existing getDocumentData utility.

@jacobsfletch jacobsfletch changed the title feat(next): passes doc through edit views fix(next): passes doc through edit views Nov 18, 2024
@jacobsfletch jacobsfletch changed the title fix(next): passes doc through edit views fix(next): passes doc through edit view handler Nov 18, 2024
@jacobsfletch jacobsfletch merged commit ec95ce8 into main Nov 18, 2024
57 checks passed
@jacobsfletch jacobsfletch deleted the fix/live-preview-requests branch November 18, 2024 19:27
Copy link

🚀 This is included in version v3.0.0-beta.135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant