Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add generic to LabelFunction to prevent type error for custom translation keys #9335

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: add generic to LabelFunction to prevent type error for custom translation keys #9335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de38ab1
fix: LabelFunction type error when merging custom keys
marwinhormiz Nov 19, 2024
ef06a26
Merge branch 'payloadcms:main' into main
marwinhormiz Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/payload/src/config/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type {
DefaultTranslationKeys,
DefaultTranslationsObject,
I18nClient,
I18nOptions,
Expand Down Expand Up @@ -493,7 +494,11 @@ export type LocalizationConfig = Prettify<
LocalizationConfigWithLabels | LocalizationConfigWithNoLabels
>

export type LabelFunction = ({ t }: { t: TFunction }) => string
export type LabelFunction<TTranslationKeys = DefaultTranslationKeys> = ({
t,
}: {
t: TFunction<TTranslationKeys>
}) => string

export type StaticLabel = Record<string, string> | string

Expand Down