Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(richtext-lexical): fully-typed blocks in JSX serializer #9554

Merged
merged 7 commits into from
Nov 27, 2024
Merged

feat(richtext-lexical): fully-typed blocks in JSX serializer #9554

merged 7 commits into from
Nov 27, 2024

Commits on Nov 27, 2024

  1. feat(richtext-lexical): add generic to JSXConvertersFunction type, to… 

    … extend it with custom node types
    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    dc12d7a View commit details
    Browse the repository at this point in the history

  2. feat(richtext-lexical): add generic to SerializedInlineBlockNode type

    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    917bd82 View commit details
    Browse the repository at this point in the history

  3. fix imports

    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    7c024cd View commit details
    Browse the repository at this point in the history

  4. feat(richtext-lexical): fully-typed blocks in JSX serializer types

    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    6fb5cd8 View commit details
    Browse the repository at this point in the history

  5. add comment

    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    363a3ec View commit details
    Browse the repository at this point in the history

  6. fix: ensure defaultConverters type is compatible with whatever generi… 

    …c the user may pass (assuming it includes DefaultNodeTypes - otherwise, defaultConverters shouldn't be spread anyways)
    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    451666e View commit details
    Browse the repository at this point in the history

  7. ensure block field types are squeaky clean, without bad union type. B… 

    …efore: BlockFields<VideoBlock> | BlockFields<JsonObject>. Now: BlockFields<VideoBlock>
    @AlessioGr
    AlessioGr committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    61b5ea5 View commit details
    Browse the repository at this point in the history