Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): ensure Form submit button only uses onClick handler when needed, as that was causing issues with password manager extensions #9572

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

AlessioGr
Copy link
Member

No description provided.

…ded, as that was causing issues with password manager extensions
Copy link
Contributor

@franciscolourenco franciscolourenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the quick turnaround 🙏 💯

Comment on lines +24 to +30
/**
* Enables form submission via an onClick handler. This is only needed if
* type="submit" does not trigger form submission, e.g. if the button DOM
* element is not a direct child of the form element.
*
* @default false
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlessioGr AlessioGr merged commit ca07c9f into main Nov 27, 2024
58 checks passed
@AlessioGr AlessioGr deleted the fix/form-submit branch November 27, 2024 17:50
Copy link
Contributor

🚀 This is included in version v3.2.2

kendelljoseph pushed a commit that referenced this pull request Feb 21, 2025
…ded, as that was causing issues with password manager extensions (#9572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants