-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): stale locale value from useLocale #9582
Conversation
@@ -21,70 +21,44 @@ export const LocaleProvider: React.FC<{ children?: React.ReactNode }> = ({ child | |||
const defaultLocale = | |||
localization && localization.defaultLocale ? localization.defaultLocale : 'en' | |||
|
|||
const { getPreference, setPreference } = usePreferences() | |||
const { searchParams } = useSearchParams() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of relying on the search params provider for locale here, you should use next/navigation
directly and parse the search params yourself. Check out #9581
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a typosquat?Package name is similar to other popular packages and may not be the package you want. Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
🚀 This is included in version v3.5.0 |
What?
Fixes issue with stale locale from searchParams
Why?
Bad use of useEffect/useState inside our useSearchParams provider.
How?
Memoize the locale instead of relying on the useEffect which was causing unnecessary renders with stale values.