Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): incorrect label size for group field #9740

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

JarrodMFlesch
Copy link
Contributor

@JarrodMFlesch JarrodMFlesch commented Dec 4, 2024

What?

The group label was incorrectly sized.

CleanShot 2024-12-04 at 10 33 13

Why?

It should be rendered as a span not a label.

How?

Added as="span" to the FieldLabel for the group field like we do for the array field.

CleanShot 2024-12-04 at 10 35 13

@JarrodMFlesch JarrodMFlesch changed the title fix: incorrect label size for group field fix(ui): incorrect label size for group field Dec 4, 2024
@JarrodMFlesch JarrodMFlesch merged commit 4a324a9 into main Dec 4, 2024
62 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/group-label branch December 4, 2024 16:13
Copy link
Contributor

github-actions bot commented Dec 6, 2024

🚀 This is included in version v3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant