fix(ui): properly sync field values in bulk upload preventing stale data overriding old docs

[akhrarovsaid]

What?

This PR fixes an issue where bulk upload on an upload field with hasMany, which had errors on sequential uploads, caused only the last successful upload to be saved to the field value.

Why?

To save all successful uploads to the field value and sync what was shown in the ui to the actual field data.

How?

By triggering a rerender that syncs populatedDocs to the fields value on each sequential successful upload after form errors were resolved.

Fixes #9890

Before:
Bulk-upload-before--Post---Payload.webm

After:
Bulk-upload-after---Payload.webm

Notes:

• The core issue was that onSuccess function was not properly syncing the correct field values resulting in stale values that would overwrite old docs.

[PatrikKozak]

Hey @akhrarovsaid - Thanks for taking the time to solve this!

I did some digging / testing and your approach does seem to work but I think there is a simpler way to fix #9890

You're right that the onSuccess function is basically stale in the above scenario so you should simply just need to add this effect in the Upload / Input file:

React.useEffect(() => {
    setOnSuccess(onUploadSuccess)
  }, [value, onUploadSuccess, setOnSuccess])

and then remove other usage of setOnSuccess from that file and your current PR changes.

If you want to make this change, I'll review it once more afterwards - if you're busy, I can also go ahead and make a PR for this - let me know!

[github-actions]

🚀 This is included in version v3.9.0