Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join collection read access #9930

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: join collection read access #9930

merged 2 commits into from
Dec 12, 2024

Conversation

DanRibbens
Copy link
Contributor

fixes #9922 #9865

@DanRibbens DanRibbens changed the title fix(graphql): join collection read access fix: join collection read access Dec 12, 2024
@DanRibbens DanRibbens linked an issue Dec 12, 2024 that may be closed by this pull request
@DanRibbens DanRibbens merged commit 5af71fb into main Dec 12, 2024
48 of 54 checks passed
@DanRibbens DanRibbens deleted the fix/join-graphql branch December 12, 2024 17:01
Copy link
Contributor

🚀 This is included in version v3.7.0

DanRibbens added a commit that referenced this pull request Dec 14, 2024
In PR #9930 we added `overrideAccess: false` to the find operation and
failed to pass the user. This caused
#9974 where any access
control causes the edit view to error.

The fix was to pass the user through.

This change also adds Join Field e2e tests to the CI pipeline which was
previously missing and would have caught the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Join Field Access ignored Join field violating access control of other collection
1 participant