Fix: Fix issue with React example re-renders #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kand
approved these changes
Sep 17, 2025
hamzanasir
reviewed
Sep 17, 2025
| return () => { | ||
| if ( | ||
| paypalSession.current && | ||
| typeof paypalSession.current.destroy === "function" |
There was a problem hiding this comment.
Do we have to do this check? I would assume destroy always exists if the paypalSession exists?
| return () => { | ||
| if ( | ||
| venmoSession.current && | ||
| typeof venmoSession.current.destroy === "function" |
| paymentSessionOptions, | ||
| ); | ||
| } | ||
| }, [sdkInstance, paymentSessionOptions]); |
There was a problem hiding this comment.
We would like to re-initialize the session if paymentSessionOptions changes right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a few stray issues in
sdkContext.tsxandutils.ts. Slightly refactors the PayPal and Venmo buttons to prevent new sessions from being created.