Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce output size when using suggestions?all API #194

Closed
pjeli opened this issue Feb 28, 2019 · 2 comments
Closed

Reduce output size when using suggestions?all API #194

pjeli opened this issue Feb 28, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
1.6.1 Release

Comments

@pjeli
Copy link
Collaborator

pjeli commented Feb 28, 2019

Today if you make a call to /suggestions?all you will get a dump of every users /suggestions call. There is some duplicate data shown here however, such as timeTaken, and numFiles and numDirs, which represent the time of the report and the number of files and directories across the entire cluster. Removing these will save time of this expensive call.
@pjeli pjeli added the enhancement New feature or request label Feb 28, 2019
@pjeli pjeli added this to the 1.6.1 Release milestone Feb 28, 2019
@pjeli
Copy link
Collaborator Author

pjeli commented Mar 5, 2019 •
edited
Loading

The exact list to remove: totalFiles, totalDirs, capacity, timeTaken, reportTime, nextReportEstimate.

@pjeli
Copy link
Collaborator Author

pjeli commented Mar 5, 2019

There were 46 entries initially and now there will only be 40. Just shy of a 15% reduction overall.

pjeli added a commit to pjeli/NNAnalytics that referenced this issue Mar 5, 2019
@pjeli
[paypal#194] Reduce output size when using suggestions?all API
2851638
@pjeli pjeli mentioned this issue Mar 5, 2019
Merged
4 tasks
@pjeli pjeli closed this as completed in #201 Mar 5, 2019
pjeli added a commit that referenced this issue Mar 5, 2019
@pjeli
[#194] Reduce output size when using suggestions?all API
d1b880c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.1 Release
Development

No branches or pull requests
1 participant
@pjeli