Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#152] Remove tidy.html and tokens.html and reveal users.html in navbar #158

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

pjeli
Copy link
Collaborator

@pjeli pjeli commented Nov 27, 2018

Make sure you have checked all steps below.

GitHub Issue

Fixes #152

Checklist:

  • This pull request updates the documentation
  • This pull request changes the code
  • Title of the PR is of format (example) : [#25] Add Pull Request Template, where [#25] is the GitHub issue number

What is the purpose of this pull request?

How was this change validated?

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #158 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.08%   76.92%   -0.17%     
+ Complexity     1073     1069       -4     
============================================
  Files            40       40              
  Lines          5585     5585              
  Branches        516      516              
============================================
- Hits           4305     4296       -9     
- Misses          967      974       +7     
- Partials        313      315       +2
Impacted Files Coverage Δ Complexity Δ
...op/hdfs/server/namenode/JavaCollectionQEngine.java 72.33% <0%> (-0.56%) 237% <0%> (-2%)
...c/main/java/com/paypal/namenode/WebServerMain.java 75.63% <0%> (-0.2%) 115% <0%> (-1%)
...op/hdfs/server/namenode/JavaStreamQueryEngine.java 78.03% <0%> (-0.13%) 224% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79d0c5...9c8694a. Read the comment docs.

@pjeli pjeli merged commit 4b650fe into paypal:master Nov 27, 2018
@pjeli pjeli deleted the issue-152 branch November 27, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant