Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Commit

Permalink
tech(node): add node as a dep.
Browse files Browse the repository at this point in the history
Closes #352
  • Loading branch information
Kent C. Dodds committed Feb 21, 2018
1 parent 65c2376 commit d493897
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ Thanks for being willing to contribute!
## Project setup

1. Fork and clone the repo
2. `$ npm install` to install dependencies
3. `$ npm run validate` to validate you've got it working
4. Create a branch for your PR
2. `npm run setup --silent` to setup the project (it installs deps and runs the validate script)
3. Create a branch for your PR

> Tip: Keep your `master` branch pointing at the original repository and make
> pull requests from branches on your fork. To do this, run:
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"test:build": "kcd-scripts test --config other/jest.config.js --no-watch",
"build-and-test": "npm run build -s && npm run test:build -s",
"validate": "kcd-scripts validate lint,build-and-test,test:cover",
"setup": "npm install && npm run validate --silent",
"precommit": "kcd-scripts precommit"
},
"files": ["dist", "typings", "preact"],
Expand Down Expand Up @@ -56,6 +57,7 @@
"glamor": "^2.20.37",
"jest-glamor-react": "^3.2.2",
"kcd-scripts": "^0.31.1",
"node": "^8.9.4",
"npm-run-all": "^4.1.2",
"preact": "^8.2.7",
"preval.macro": "^1.0.2",
Expand Down

0 comments on commit d493897

Please sign in to comment.