Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

fix(typescript): Correct type for the withTheme higher order component #190

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

luke-john
Copy link
Collaborator

What:

Corrects the type (typescript) for the withTheme higher component

Why:

How:

Checklist:

  • Documentation N/A
  • Tests
  • Code complete
  • Added myself to contributors table N/A
  • Followed the commit message format

@luke-john luke-john requested review from ErikCupal and kokjinsam June 20, 2017 08:14
@atticoos atticoos mentioned this pull request Jun 20, 2017
@codecov-io
Copy link

codecov-io commented Jun 20, 2017

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #190   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         142    142           
  Branches       36     36           
=====================================
  Hits          142    142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffffe2...90a4840. Read the comment docs.

@luke-john
Copy link
Collaborator Author

Looks like I don't have write access to merge this.

In the future I'm happy to merge typescript prs that have passed review if I can get that permission.

Copy link
Collaborator

@ErikCupal ErikCupal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good :)

@kentcdodds kentcdodds merged commit c828d94 into paypal:master Jun 22, 2017
@kentcdodds
Copy link
Contributor

Weird that you don't have merge rights... 🤔 I'll give it a look when I get back from my trip 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants