Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

fix(deps): Update react version in peer dependency requirement to include react>=0.14 #200

Merged
merged 2 commits into from
Jun 28, 2017

Conversation

majapw
Copy link
Contributor

@majapw majapw commented Jun 28, 2017

Fix for #199

What:
Glamorous was intended to support react 14, but the package.json didn't actually allow for it to be installed alongside react 14 by mistakenly using a peer dep requirement of >=14 instead of >=0.14.

Why:
Glamorous (and packages that rely on it) might want to use react 14.

How:
Updated the package.json

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Added myself to contributors table
  • Followed the commit message format

Copy link
Contributor

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you!

@kentcdodds kentcdodds merged commit a70eab3 into paypal:master Jun 28, 2017
@codecov-io
Copy link

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         142    142           
  Branches       36     36           
=====================================
  Hits          142    142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72511a2...484022b. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants