fix(react): add react-compat to deal with the warnings #32
Conversation
kentcdodds
force-pushed
the
pr/react-compat
branch
from
6d3a324 to
c0b6c89
Compare
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 62 61 -1
Branches 9 9
=====================================
- Hits 62 61 -1
Continue to review full report at Codecov.
|
README.md
Outdated
| @@ -132,6 +135,7 @@ If you want to use the global: | |||
| ```html | |||
| <!-- Load dependencies --> | |||
| <script src="https://unpkg.com/react/dist/react.js"></script> | |||
| <script src="https://packd.now.sh/prop-types?name=PropTypes"></script> | |||
There was a problem hiding this comment.
This is assuming the service works (which it's not right now) and it has no SLA. Not a huge deal because this is really only for demos and toys anyway...
package.json
Outdated
| "react-dom": "^15.4.2", | ||
| "prop-types": "^15.5.1", | ||
| "react": "^15.5.1", | ||
| "react-addons-test-utils": "^15.5.0", |
There was a problem hiding this comment.
This is still required until this gets merged: enzymejs/enzyme#876
| globals: { | ||
| react: 'React', | ||
| glamor: 'Glamor', | ||
| 'prop-types': 'PropTypes', |
React@15.5.0 introduced deprecation warnings for a few things and they're really annoying. So this will help prevent those warnings from logging for people using this package.
kentcdodds
force-pushed
the
pr/react-compat
branch
from
c0b6c89 to
de50b7c
Compare
|
Will review this tonight @kentcdodds. |
|
I'm getting these errors after running
|
There was a problem hiding this comment.
Commented with an error I'm seeing:
[test] console.error node_modules/fbjs/lib/warning.js:36
[test] Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.
[test]
[test] console.error node_modules/fbjs/lib/warning.js:36
[test] Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.
Also, this branch is behind master by 1 commit.
|
That error is coming from enzyme. Will be fixed soon: enzymejs/enzyme#876 Don't worry about dependency CI. I actually fixed that a bit ago. Just takes time for dependency CI to pick up on the change. |
React@15.5.0 introduced deprecation warnings for a few things and they're really annoying. So this will help prevent those warnings from logging for people using this package.