tech(node): add node as a dep. #388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 177 177
Branches 50 50
=====================================
Hits 177 177Continue to review full report at Codecov.
|
| 2. `$ npm install` to install dependencies | ||
| 3. `$ npm run validate` to validate you've got it working | ||
| 4. Create a branch for your PR | ||
| 2. `npm run setup --silent` to setup the project (it installs deps and runs the validate script) |
There was a problem hiding this comment.
I don't think the --silent is needed here, that's already been added to the validate command under the setup script.
There was a problem hiding this comment.
Nope, still need it to prevent npm from logging useless stuff when running the command I'm afraid.
package.json
Outdated
| @@ -56,6 +57,7 @@ | |||
| "glamor": "^2.20.37", | |||
| "jest-glamor-react": "^3.2.2", | |||
| "kcd-scripts": "^0.31.1", | |||
| "node": "^8.9.4", | |||
There was a problem hiding this comment.
Great idea adding this, hopefully it should make contributing a bit easier and cut down on issues around node versions 🙂.
|
That's really cool
Is there a source you could share? Tried to find more information about this, but it's a tricky search term to research and didn't seem to find anything in https://docs.npmjs.com/files/package.json 😛 |
|
This is as official as I could get: https://twitter.com/maybekatz/status/958157474397171712 It's not an npm thing actually. It's just a normal npm package! Pretty interesting exercise to go through the code actually if you're curious. Start here: https://unpkg.com/node/ |
|
Thanks! Forgot to follow up and mention the README of https://www.npmjs.com/package/node pretty much sums it up |
What: Adds node as a dependency. This is a brilliant idea from the folks at npm. It allows us to have any version of node and as long as the folks using the project only use npm scripts to run our stuff, the installed version of node will be the one used!
Why: Closes #352
How: add node to the dev dependencies and update contributing docs to be a little simpler.
Checklist: