Added implementation,testcases for validate text and validate attribute #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: README.md lib/locreator.js test/methods.js
| @@ -75,6 +75,12 @@ Locreator.prototype.addStarMethods = function locreator(locatorId, _locator, par | |||
| locatorObject[locatorId + 'OptionValue'] = function (optionValue) { | |||
| return drivex.selectByOptionValue(locator, optionValue, parentWebElement); | |||
| }; | |||
| locatorObject[locatorId + 'ValidateText'] = function (ValidateText) { | |||
There was a problem hiding this comment.
What about calling the method "TextEquals" instead? Trying to shorten the name if possible
There was a problem hiding this comment.
function argument should begin with lowercase letter
There was a problem hiding this comment.
can you change the name of this argument to comparisonText or something else that succinctly describes its purpose?
There was a problem hiding this comment.
Changing name to TextEquals and AttrEquals
| #### [locatorName]TextEquals | ||
|
|
||
| * arguments | ||
| * text: the expected text on the element |
There was a problem hiding this comment.
in the code the parameter is value so it should match in the doc
grawk
added a commit
that referenced
this pull request
May 22, 2015
Added implementation,testcases for validate text and validate attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.