Remove request type from metadata.

paypal · Nov 5, 2024 · 70a0d62 · 70a0d62
1 parent c0d455a
commit 70a0d62
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/CardPayments/src/main/java/com/paypal/android/cardpayments/CardAuthLauncher.kt b/CardPayments/src/main/java/com/paypal/android/cardpayments/CardAuthLauncher.kt
@@ -14,10 +14,6 @@ internal class CardAuthLauncher(
 ) {
 
     companion object {
-        private const val METADATA_KEY_REQUEST_TYPE = "request_type"
-        private const val REQUEST_TYPE_APPROVE_ORDER = "approve_order"
-        private const val REQUEST_TYPE_VAULT = "vault"
-
         private const val METADATA_KEY_ORDER_ID = "order_id"
         private const val METADATA_KEY_SETUP_TOKEN_ID = "setup_token_id"
     }
@@ -30,14 +26,12 @@ internal class CardAuthLauncher(
             is CardAuthChallenge.ApproveOrder -> {
                 val request = authChallenge.request
                 JSONObject()
-                    .put(METADATA_KEY_REQUEST_TYPE, REQUEST_TYPE_APPROVE_ORDER)
                     .put(METADATA_KEY_ORDER_ID, request.orderId)
             }
 
             is CardAuthChallenge.Vault -> {
                 val request = authChallenge.request
                 JSONObject()
-                    .put(METADATA_KEY_REQUEST_TYPE, REQUEST_TYPE_VAULT)
                     .put(METADATA_KEY_SETUP_TOKEN_ID, request.setupTokenId)
             }
         }

diff --git a/CardPayments/src/test/java/com/paypal/android/cardpayments/CardAuthLauncherUnitTest.kt b/CardPayments/src/test/java/com/paypal/android/cardpayments/CardAuthLauncherUnitTest.kt
@@ -37,11 +37,9 @@ class CardAuthLauncherUnitTest {
     private val card = Card("4111111111111111", "01", "25", "123")
 
     private val approveOrderMetadata = JSONObject()
-        .put("request_type", "approve_order")
         .put("order_id", "fake-order-id")
 
     private val vaultMetadata = JSONObject()
-        .put("request_type", "vault")
         .put("setup_token_id", "fake-setup-token-id")
 
     @Before
@@ -81,7 +79,6 @@ class CardAuthLauncherUnitTest {
 
         val browserSwitchOptions = slot.captured
         val metadata = browserSwitchOptions.metadata
-        assertEquals("approve_order", metadata?.getString("request_type"))
         assertEquals("fake-order-id", metadata?.getString("order_id"))
         assertEquals("merchant.app", browserSwitchOptions.returnUrlScheme)
         assertEquals(Uri.parse("https://fake.com/destination"), browserSwitchOptions.url)
@@ -104,7 +101,6 @@ class CardAuthLauncherUnitTest {
 
         val browserSwitchOptions = slot.captured
         val metadata = browserSwitchOptions.metadata
-        assertEquals("vault", metadata?.getString("request_type"))
         assertEquals("fake-setup-token-id", metadata?.getString("setup_token_id"))
         assertEquals("merchant.app", browserSwitchOptions.returnUrlScheme)
         assertEquals(Uri.parse("https://fake.com/destination"), browserSwitchOptions.url)