-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub Actions] Create Workflow to Deploy Demo App to Google Play #201
Conversation
Demo/build.gradle
Outdated
@@ -16,12 +17,11 @@ android { | |||
applicationId "com.paypal.android" | |||
minSdkVersion 21 | |||
targetSdkVersion 33 | |||
versionCode 1 | |||
versionCode 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a step in this workflow to bump this? It will fail if it's not a higher number than previous version right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! I was hoping to do a couple YOLO commits to verify that GitHub Actions before adding version code bump automation. I've been able to deploy from the command line on my local workstation so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up updating the script to do this automatically 👍.
Is there a site similar to TestFlight where we can go to see that a build was properly published? Also how do we prevent the build from hitting the actual Play Store? |
Yeah! The Google Play Console will be the place. I'm gonna add a docs guide internally once everything's wrapped up. |
storeFile file(System.getenv('DEMO_KEYSTORE_FILE') ?: 'debug.keystore') | ||
storePassword System.getenv('DEMO_KEYSTORE_PASSWORD') ?: 'android' | ||
keyAlias System.getenv('DEMO_KEY_ALIAS') ?: 'androiddebugkey' | ||
keyPassword System.getenv('DEMO_KEY_PASSWORD') ?: 'android' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these variables need to be set locally in order to do a command-line deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do need to be set yes, but they'll be set in the CI environment. I did some manual deploys early on but it should all be automated going forward.
versionCode modules.sdkVersionCode | ||
versionName modules.sdkVersionName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these properties form library modules since they no longer apply (reference).
Summary of changes
Checklist
- [ ] Added a changelog entryAuthors