Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] Create Workflow to Deploy Demo App to Google Play #201

Merged
merged 12 commits into from
Oct 24, 2023

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Oct 16, 2023

Summary of changes

  • Use the Triple-T/gradle-play-publisher 3rd-party plugin to enable push button deployments of the Demo app to Google Play
  • Create GitHub Action to deploy to Google Play manually

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire marked this pull request as ready for review October 16, 2023 19:42
@sshropshire sshropshire requested a review from a team as a code owner October 16, 2023 19:42
@@ -16,12 +17,11 @@ android {
applicationId "com.paypal.android"
minSdkVersion 21
targetSdkVersion 33
versionCode 1
versionCode 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a step in this workflow to bump this? It will fail if it's not a higher number than previous version right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I was hoping to do a couple YOLO commits to verify that GitHub Actions before adding version code bump automation. I've been able to deploy from the command line on my local workstation so far.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up updating the script to do this automatically 👍.

@scannillo
Copy link
Collaborator

Is there a site similar to TestFlight where we can go to see that a build was properly published? Also how do we prevent the build from hitting the actual Play Store?

@sshropshire
Copy link
Collaborator Author

Is there a site similar to TestFlight where we can go to see that a build was properly published? Also how do we prevent the build from hitting the actual Play Store?

Yeah! The Google Play Console will be the place. I'm gonna add a docs guide internally once everything's wrapped up.

Comment on lines +68 to +71
storeFile file(System.getenv('DEMO_KEYSTORE_FILE') ?: 'debug.keystore')
storePassword System.getenv('DEMO_KEYSTORE_PASSWORD') ?: 'android'
keyAlias System.getenv('DEMO_KEY_ALIAS') ?: 'androiddebugkey'
keyPassword System.getenv('DEMO_KEY_PASSWORD') ?: 'android'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these variables need to be set locally in order to do a command-line deploy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do need to be set yes, but they'll be set in the CI environment. I did some manual deploys early on but it should all be automated going forward.

Comment on lines -12 to -13
versionCode modules.sdkVersionCode
versionName modules.sdkVersionName
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these properties form library modules since they no longer apply (reference).

@sshropshire sshropshire merged commit ef8390a into main Oct 24, 2023
@sshropshire sshropshire deleted the prepare_demo_app_for_google_play branch October 24, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants