Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse Publish Demo Workflow Order of Operations #206

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Reverse Publish Demo Workflow Order of Operations #206

merged 2 commits into from
Nov 13, 2023

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • The bump of the version code number was not being updated in the release artifact
  • It appears to be a general issue with the GitHub Checkout action
  • Downstream jobs don't receive the recently pushed commit with the bumped version number
  • We can work around this by pushing the version code changes after a release to Google Play (similar to how we do for releases to maven central).

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner November 8, 2023 16:51
jaxdesmarais
jaxdesmarais approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

@sshropshire sshropshire merged commit 2142f97 into main Nov 13, 2023
6 checks passed
@sshropshire sshropshire deleted the reverse_publish_demo_workflow_order_of_ops branch November 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshropshire @jaxdesmarais @scannillo