Updating Android Native Checkout Version to 1.2.0 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify setting AuthConfig
sshropshire
approved these changes
Nov 15, 2023
warmkesselj
approved these changes
Nov 16, 2023
jaxdesmarais
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Can we update properties and the changelog to match the BT android PR: braintree/braintree_android#829
...Payments/src/main/java/com/paypal/android/paypalnativepayments/PayPalNativeCheckoutClient.kt
Outdated
Show resolved
Hide resolved
...ayments/src/main/java/com/paypal/android/paypalnativepayments/PayPalNativeCheckoutRequest.kt
Outdated
Show resolved
Hide resolved
...ayments/src/main/java/com/paypal/android/paypalnativepayments/PayPalNativeCheckoutRequest.kt
Outdated
Show resolved
Hide resolved
Clarify documentation
jaxdesmarais
approved these changes
Nov 17, 2023
1 task
sarahkoop
added a commit
that referenced
this pull request
Nov 17, 2023
* -Adding in auth config and tests * -Updating nxo version * -Adding changelog * Update misc.xml * remove new line * Pass in AuthConfig only if userEmail is present. * Fix test * Add email field directly to request object Simplify setting AuthConfig * Fix test * Update CHANGELOG.md * Rename email to userAuthenticationEmail Clarify documentation * Reduce line length of comment --------- Co-authored-by: chpypl <123016118+chpypl@users.noreply.github.com> Co-authored-by: Kevin Lay <kelay@paypal.com> Co-authored-by: kelay858 <109249624+kelay858@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to PayPal.
Summary of changes
Checklist
Authors