Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Demo App Assembly During CI Release #217

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Skip Demo App Assembly During CI Release #217

merged 1 commit into from
Nov 20, 2023

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • Demo app now requires a signing configuration when a release is built
  • We can skip the :Demo:assemble goal in our GitHub Actions release goal
  • It turns out snapshot_release.yml does this already. This PR will improve alignment between the release and release_snapshot workflows

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner November 20, 2023 15:32
@sshropshire sshropshire merged commit 71d681e into main Nov 20, 2023
6 checks passed
@sshropshire sshropshire deleted the fix_assemble_ci branch November 20, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshropshire @jaxdesmarais @scannillo