Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from JetPack Navigation to Compose Navigation #218

Merged
merged 31 commits into from
Nov 30, 2023
Merged

Migrate from JetPack Navigation to Compose Navigation #218

merged 31 commits into from
Nov 30, 2023

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Nov 21, 2023 •
edited
Loading

Summary of changes

  • Migrating to Compose Navigation allows us to move the Demo app to 100% usage of Compose UI
  • Every demoable feature's associated Fragment instance has been deleted
  • Demo App compileSdkVersion and targetSdkVersion is now API Level 34
  • The SDK target API versions are unchanged, but we should consider bumping these up in a future release
  • DemoActivity has been renamed to MainActivity

Screenshots

screen-20231127-103536.mp4

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire
Bump compile sdk and target sdk version to 34 and add navigation-comp…
0aa6160 
…ose dependency to demo app.
@sshropshire
Rename DemoActivity to main activity.
56d1f7a
@sshropshire
Rename DemoApplication to MainApplication.
4a4cf23
@sshropshire
Remove Jetpack Navigation configuration from MainActivity.
90b36e5
@sshropshire
Add compose navigation view.
8893c88
@sshropshire
Add hilt navigation compose to project.
9bf5212
@sshropshire
Migrate test card approve order to Jetpack navigation compose.
6c9d2a7
@sshropshire
Remove ApproveOrderFragment.
f013484
@sshropshire
Remove features fragment from project.
4c84553
@sshropshire
Add Card Vault destination to project.
e29e064
@sshropshire
Remove VaultCardFragment from project.
8a32081
@sshropshire
Add PayPalWebView and remove PayPalWebFragment.
ec25bfd
@sshropshire
Add PayPalButtons view to compose navigation configuration.
5c0fa4c
@sshropshire
Add PayPal Native flow to jetpack compose navigation configuration.
d1c87fa
@sshropshire
Remove SelectCardFragment.
1d1689e
@sshropshire
Add onNewIntent override to MainActivity.
9372529
@sshropshire
Remove action bar.
a3c633c
@sshropshire
Add app bar to project.
b404764
@sshropshire
Update title text based on current back stack entry destination.
54f5fcd
@sshropshire
Conditionally add back button to app bar.
b79d10c
@sshropshire
Revert build.gradle androidTargetVersion to 30.
c695de8
@sshropshire
Clean up lint errors and unused imports.
90a6f06
@sshropshire
Suppress long method lint error in Demo app until we find a better wa…
cc27fc0 
…y to reduce line count of this composable.
@sshropshire
Make code more DRY and extract NavDestinationChangeDisposableEffect.
4abdd24
@sshropshire
Fix lint errors.
4ce593c
@sshropshire
Fix package naming.
df70469
@sshropshire
Cleanup Android lint errors and remove unecessary resource files.
c552ca4
@sshropshire sshropshire marked this pull request as ready for review November 27, 2023 16:43
@sshropshire sshropshire requested a review from a team as a code owner November 27, 2023 16:43
@sshropshire sshropshire merged commit 227eed9 into main Nov 30, 2023
6 checks passed
@sshropshire sshropshire deleted the compose_navigation branch November 30, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshropshire @jaxdesmarais @sarahkoop