3ds - onClose

[hnguyen510]

Calling onClose for 3Ds to fix issue for this ticket (LI-63320).

[mchoun]

Was this tested to confirm that the onError callback is still executed? I took a look at the ticket and it wasn't clear what the root cause of the issue is.

I think that this conditional will not execute onError if result.success = false which was fixed in ticket DTPPCPSDK-2207.

[hnguyen510]

@mchoun I think that onError will execute if isCardFieldFlow is false. I am not sure how to test onError on xotestbed. Can you give some suggestion please. Do you think I should move my onClose after the onError so that on Error could still be execute?

[ravishekhar]

🎉

[mchoun]

@mchoun I think that onError will execute if isCardFieldFlow is false. I am not sure how to test onError on xotestbed. Can you give some suggestion please. Do you think I should move my onClose after the onError so that on Error could still be execute?

I think the best way to test that onError is still being executed properly is by passing something like a console.log() into the onError call back and simulate a result.success = false response from helios.

After looking at this fix we made here, it's actually not the onError scenario that I'm worried about. We want to make sure that that we are still calling onApprove if result.success = false since that is still a valid scenario.

[hnguyen510]

Based on my understanding of the slack thread, onCancel doesn't mean it 3ds is cancelled. We will still passed additional information like onApprove, but the work will be on a different ticket.