Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v2 Migration Guide for GA #317

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Update v2 Migration Guide for GA #317

merged 4 commits into from
Feb 4, 2025

Conversation

KunJeongPark
Copy link
Collaborator

Summary of changes

  • Update migration guide to include change of return type to merchants from tuple of optionals to ResultType

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark KunJeongPark requested a review from a team as a code owner February 4, 2025 16:09

This guide helps you migrate your code from version 1.x or 2.0.0-beta1 to 2.0.0-beta2.
This guide helps you migrate your code from version 1.x or 2.0.0-beta releases to 2.0.0 GA.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This guide helps you migrate your code from version 1.x or 2.0.0-beta releases to 2.0.0 GA.
This guide helps you migrate your code from version 1.x to 2.x.

small 🧶 if it makes sense: I'm not sure if GA is something we say externally. If we keep GA, I would spell out the abbreviation in case a merchant doesn't know what it means.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@KunJeongPark KunJeongPark merged commit ecd6b31 into main Feb 4, 2025
6 checks passed
@KunJeongPark KunJeongPark deleted the ga-migration-guide branch February 4, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants