Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: general analytics fixes #36

Merged
merged 6 commits into from
May 14, 2024
Merged

fix: general analytics fixes #36

merged 6 commits into from
May 14, 2024

Conversation

merlinpaypal
Copy link
Contributor

Description

  • make events lowercase
  • make style color, logo type, and text alignment, lowercase
  • change text align to text alignment
  • change presentment channel to upstream
  • change message click link name to "Learn more" and source to "learn_more"
  • change modal amount to send empty instead of null

Testing instructions

  1. Use a stage client ID, tag, and environment (recommended ones in Slack)
  2. Render a message on stage
  3. Look for updated events and values in Lighthouse

@merlinpaypal merlinpaypal merged commit ff2ac5a into develop May 14, 2024
6 of 7 checks passed
@merlinpaypal merlinpaypal deleted the fix/analytics-fixes branch May 14, 2024 16:03
github-actions bot pushed a commit that referenced this pull request May 14, 2024
## [1.0.0-develop.3](1.0.0-develop.2...1.0.0-develop.3) (2024-05-14)

### Bug Fixes

* general analytics fixes ([#36](#36)) ([ff2ac5a](ff2ac5a))
* modal analytics fixes ([#37](#37)) ([c95246f](c95246f))
Copy link
Contributor

🎉 This PR is included in version 1.0.0-develop.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request May 14, 2024
## 1.0.0 (2024-05-14)

### Features

* accessibility ([#31](#31)) ([20644c8](20644c8))
* add instance_id  ([#4](#4)) ([d72ccee](d72ccee))
* base of GitHub workflows ([#5](#5)) ([c32defe](c32defe))
* create a snapshot workflow ([#22](#22)) ([5bc02da](5bc02da))
* debounce config updates ([#24](#24)) ([7d0a043](7d0a043))
* jetpack compose demo ([#10](#10)) ([a47065e](a47065e))
* modal updates ([#28](#28)) ([101ade5](101ade5))
* package pre-release ([#14](#14)) ([d63f834](d63f834))
* page type ([#26](#26)) ([c79e439](c79e439))
* remove session id and device id ([#35](#35)) ([20367ca](20367ca))
* session id and device id ([#30](#30)) ([a7208eb](a7208eb))
* update message view to use its own instance id ([#20](#20)) ([9efb3bb](9efb3bb))
* use nested coroutine to prevent blocking ([#19](#19)) ([b06039c](b06039c))
* xml demo ([#6](#6)) ([4b33504](4b33504))

### Bug Fixes

* allow messages to be updated any time ([#34](#34)) ([ef69ce9](ef69ce9))
* correct urls ([#32](#32)) ([f72ffda](f72ffda))
* general analytics fixes ([#36](#36)) ([ff2ac5a](ff2ac5a))
* modal analytics fixes ([#37](#37)) ([c95246f](c95246f))
* remove kotlinter ([1550f44](1550f44))
* update shared data ([#7](#7)) ([2fa1ea1](2fa1ea1))
* update tracking format ([#33](#33)) ([dc8dd61](dc8dd61))

### Code Refactoring

* adjust logo alignment ([#23](#23)) ([6347be3](6347be3))
* clone to prevent shallow copy ([#25](#25)) ([acfc3ff](acfc3ff))
* prevent destroying modal on close ([#3](#3)) ([ae7e032](ae7e032))
* prevent empty values ([#29](#29)) ([b7b746f](b7b746f))
* radio offer type and other things ([#11](#11)) ([960a48a](960a48a))
* route changes ([#13](#13)) ([6434e30](6434e30))
* use dot getters and setters ([#9](#9)) ([84316bb](84316bb))

### Continuous Integration

* change os ([#38](#38)) ([f7da086](f7da086))
* functional tests ([#16](#16)) ([51d9ec6](51d9ec6))
* lint and test ([#8](#8)) ([8a22f0b](8a22f0b))
* update semantic release ([#21](#21)) ([a9a3fb8](a9a3fb8))
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants