Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the test coverage on the client to avoid failing checks in the CI #117

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

borodovisin
Copy link
Contributor

Description

The PR contains a new set of unit tests to increase the client(Karma) code coverage.

Why are we making these changes?

To avoid the failing CI check related to the client unit tests. Now is set to a minimum of 50% on the Codecov config. Previously we had a code coverage under the desire 50% of coverage and CI check fails for all the PRs.

Note

The name of the test cases probably aren't accurate, any feedback on that is welcome.

@borodovisin borodovisin requested a review from a team as a code owner February 28, 2022 12:32
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #117 (6a96c30) into main (32f85dd) will increase coverage by 3.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   60.97%   64.74%   +3.76%     
==========================================
  Files          20       20              
  Lines         451      451              
  Branches       35       35              
==========================================
+ Hits          275      292      +17     
+ Misses        176      159      -17     
Flag Coverage Δ
client 54.17% <ø> (+4.89%) ⬆️
server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/global.js 100.00% <0.00%> (+56.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f85dd...6a96c30. Read the comment docs.

@borodovisin borodovisin force-pushed the DTPPSDK-684/client-test branch from 884bb3e to af4462c Compare February 28, 2022 12:53
test/client/global.js Outdated Show resolved Hide resolved
@borodovisin borodovisin force-pushed the DTPPSDK-684/client-test branch from af4462c to e7086bd Compare February 28, 2022 18:09
test/client/global.js Outdated Show resolved Hide resolved
@borodovisin borodovisin force-pushed the DTPPSDK-684/client-test branch from e7086bd to c8aa61a Compare February 28, 2022 20:35
test/client/global.js Outdated Show resolved Hide resolved
test/client/global.js Outdated Show resolved Hide resolved
test/client/global.js Outdated Show resolved Hide resolved
test/client/global.js Outdated Show resolved Hide resolved
test/client/global.js Outdated Show resolved Hide resolved
@borodovisin borodovisin force-pushed the DTPPSDK-684/client-test branch from c8aa61a to 6a96c30 Compare February 28, 2022 21:48
Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @borodovisin! 💯

@gregjopa gregjopa merged commit d9147b4 into paypal:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants