-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the test coverage on the client to avoid failing checks in the CI #117
Conversation
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 60.97% 64.74% +3.76%
==========================================
Files 20 20
Lines 451 451
Branches 35 35
==========================================
+ Hits 275 292 +17
+ Misses 176 159 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
884bb3e
to
af4462c
Compare
af4462c
to
e7086bd
Compare
e7086bd
to
c8aa61a
Compare
c8aa61a
to
6a96c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @borodovisin! 💯
Description
The PR contains a new set of unit tests to increase the client(Karma) code coverage.
Why are we making these changes?
To avoid the failing CI check related to the client unit tests. Now is set to a minimum of 50% on the Codecov config. Previously we had a code coverage under the desire 50% of coverage and CI check fails for all the PRs.
Note
The name of the test cases probably aren't accurate, any feedback on that is welcome.