Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support new method to validate url #224

Merged
merged 1 commit into from
Jan 29, 2025
Merged

feat: support new method to validate url #224

merged 1 commit into from
Jan 29, 2025

Conversation

ravishekhar
Copy link
Contributor

@ravishekhar ravishekhar commented Jan 28, 2025 •
edited
Loading

@ravishekhar ravishekhar requested a review from a team as a code owner January 28, 2025 20:40
mchoun
mchoun reviewed Jan 28, 2025
View reviewed changes
Copy link

@mchoun mchoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious where this new method is being utilized? Is it replacing all instances of getActualDomain?

@ravishekhar
Copy link
Contributor Author

I'm just curious where this new method is being utilized? Is it replacing all instances of getActualDomain?

This method will be utilized in other modules like checkout-components to validate if a particular URL is safe to be redirected to.

@ravishekhar ravishekhar merged commit a1a1781 into main Jan 29, 2025
3 checks passed
@ravishekhar ravishekhar deleted the is-trusted-url branch January 29, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchoun mchoun mchoun approved these changes

@wsbrunson wsbrunson wsbrunson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravishekhar @wsbrunson @mchoun