Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style/NumericLiterals-20230601233307 #214

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Style/NumericLiterals-20230601233307 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e423db1
:police_car: regenerate rubocop todo
Jun 1, 2023
a676614
:police_car: Style/NumericLiterals
Jun 1, 2023
1d8f472
:police_car: regenerate rubocop todo
Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 180`
# on 2023-04-20 23:33:11 UTC using RuboCop version 1.50.2.
# on 2023-06-01 23:33:27 UTC using RuboCop version 1.51.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -459,12 +459,6 @@ Style/NestedParenthesizedCalls:
- 'spec/lib/dispatch-rider/notification_services/aws_sns_spec.rb'
- 'spec/lib/dispatch-rider/notification_services/base_spec.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.
Style/NumericLiterals:
MinDigits: 6

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@

let(:response_message) do
OpenStruct.new({
message_id: 12345,
message_id: 12_345,
md5_of_body: "mmmddd555",
body: { subject: "foo", body: { bar: "baz" } }.to_json,
receipt_handle: "HANDLE",
Expand Down