Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update roo #3

Merged
merged 2 commits into from
Apr 14, 2015
Merged

Update roo #3

merged 2 commits into from
Apr 14, 2015

Conversation

more-ron
Copy link
Contributor

Feature:
This will update Roo gem fixing the sheet order issue.

Ticket:
roo-rb/roo#166 (comment)

Submitter Checklist:

  • CI Passing
  • PR Linked to Asana Ticket
  • Hound Appeased Acceptably
  • No Code Climate Issues
  • Class, Module, and public method comments up to spec

Reviewer Checklist:

  • New Code Tested Effectively
  • Code organization meets SOP standards
  • Does this code fullfill the ticket?

Only Then:

  • Move ticket in Asana

more-ron
more-ron reviewed Apr 14, 2015
View reviewed changes
lib/excel_templating/renderer.rb
end
@font_formats[font]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved the caching code and added missing font when the cell is empty. For empty cell default formal style is applied.

bramski added a commit that referenced this pull request Apr 14, 2015
@bramski
Merge pull request #3 from payrollhero/update_roo
3188df0 
Update roo
@bramski bramski merged commit 3188df0 into master Apr 14, 2015
@bramski bramski deleted the update_roo branch April 14, 2015 20:56
@bramski
Copy link
Contributor

bramski commented Apr 14, 2015

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@more-ron @bramski