Add settlements by id endpoint #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class ReportBySettlementRequest implements \JsonSerializable | ||
| { | ||
| use ObjectPropertyConverter; |
There was a problem hiding this comment.
is this ObjectPropertyConverter trait usage needed here? it may be used for the jsonSerialize method, similar in other requests, but seems not used in this class
There was a problem hiding this comment.
True, it's used only in few of the Models, but loaded in almost every one. Will remove, and from other models don't need that as well.
konrad-konieczny
previously approved these changes
Mar 30, 2023
VuorelaJ-P
force-pushed
the
addReportBySettlementIdEndpoint
branch
from
4e51a37
to
1e1847c
Compare
loueranta-paytrail
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Method for /settlements/:id/payments/report is missing, add method to said endpoint.