Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Report date validation #70

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Fix Report date validation #70

merged 2 commits into from
Mar 15, 2023

Conversation

VuorelaJ-P
Copy link
Contributor

Description

  • Report request does not work only with YYYY-MM-DD format, fix validation
  • Throw exception on CurlClient when receiving response 400

tommi-martin
tommi-martin approved these changes Mar 10, 2023
View reviewed changes
tests/ClientTest.php
->setStartDate('2023-01-20')
->setEndDate('2023-01-01');
->setStartDate('2023-01-20T12:00:00+02:00')
->setEndDate('2023-01-01T23:59:50+02:00');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should unit tests include examples of all three supported formats as noted by the validation exception?

@loueranta-paytrail loueranta-paytrail merged commit f9c3f04 into master Mar 15, 2023
@loueranta-paytrail loueranta-paytrail deleted the fixReportValidation branch March 15, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommi-martin tommi-martin tommi-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VuorelaJ-P @tommi-martin @loueranta-paytrail