Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to jump to next message matching query #806

Closed
wants to merge 4 commits into from

Conversation

arekfu
Copy link

@arekfu arekfu commented Dec 10, 2015

Hi,

This pull requests adds a jump command to thread mode to move to the next/previous message matching a specific query. I have added the following default bindings in thread mode:

/ = prompt 'jump '
n = jump
N = jump --backwards

This is intentionally similar to vim's behaviour, but I had to change the binding for editnew to 'ctrl n'.

Perhaps it might be useful to add default bindings for jump tag:unread and jump --backwards tag:unread.

Eventually I would like to add a similar feature to search buffers, but that needs a bit more work because search buffers do not have the convenient focus_next_matching and focus_prev_matching methods.

@arekfu
Copy link
Author

arekfu commented Dec 11, 2015

Oops, probably the last commit wasn't such a great idea. ? is reserved for the help screen.

@pazz
Copy link
Owner

pazz commented Dec 16, 2015

Hi!
I like the move next matching .. commands and would actually prefer only those and no hardcoded
aliases jump. Since most of us use keybindings anyway i think those are totally sufficient.
How about you send a new PR containing the move-patch, one that cleans up the
help move accordingly and maybe one that introduces some default bindings? thanks!

@lucc lucc mentioned this pull request Feb 15, 2016
@pazz
Copy link
Owner

pazz commented Nov 7, 2017

I believe that this functionality is now provided by the move next QUERY thread command.

@pazz pazz closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants