Some more fixes for building docs #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sphinx-build -W` was complaining as this is not a option of alot and can not be found in our documentation.
The path to the present development version of alot should be prepended to sys.path in order to shadow other versions of alot installed on the system. Also it should be a directory from which the alot module is loadable. That is the root of the git repository and not one level above this. This was overlooked in pazz#912.
When checking out files from git the timestamps might not give enough information to make which files to remake. So this new target can be used to force a remake of all generated files on the next run.
pazz
reviewed
Dec 11, 2016
| @@ -47,7 +57,7 @@ | |||
|
|
|||
| where to store outgoing mails, e.g. `maildir:///home/you/mail/Sent`. | |||
| You can use mbox, maildir, mh, babyl and mmdf in the protocol part of the URL. | |||
|
|
|||
There was a problem hiding this comment.
Nitpick: should we try to avoid these trailing whitespaces to be introduced?
pazz
approved these changes
Dec 11, 2016
It would otherwise be picked up by the autogenerated docs.
|
I used two different approaches to remove the trailing ws from the autogen. docs. Do you think this is ok or would you prefer to remove trailing ws in the second script as well (I think that might be a bit more difficult as with the first script). |
|
Also NB: The "Changes approved" mark from your review was not removed by github even though I pushed new commits. |
|
re reviews: yes, that's strange.. next time i'll simply hold back longer :) |
ryneeverett
pushed a commit
to ryneeverett/alot
that referenced
this pull request
Mar 13, 2020
Some more fixes for building docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry there where quite some things I overlooked in #912.